Skip to content
Snippets Groups Projects

Resolve "New ice cover friction law for KHIONE"

Merged Resolve "New ice cover friction law for KHIONE"
1087-new-ice-cover-friction-law-for-khione into main
Merged Florent Taccone requested to merge 1087-new-ice-cover-friction-law-for-khione into main

Reference issue

Description

Checklist

All Merge Requests:

  • Update NEWS.txt to describe your changes.
  • Run compile_telemac.py --check to check FORTRAN coding conventions.
  • Run pylint to check Python coding conventions.
  • If you added new files, run compile_telemac.py --clean --rescan and commit the updated cmdf file(s) accordingly.
  • Run compile_telemac.py --clean for both normal and debug configurations.
  • Run validate_telemac.py for both normal and debug configurations.
  • Run validate_telemac.py --notebook for both normal and debug configurations.
  • Run doc_telemac.py if there are any modifications in the documentation.
  • Run damocles.py --eficas if there are any modifications in the dictionaries.

In addition, for a new feature:

  • Check that your feature works in both serial and parallel modes.
  • Add at least one test case to check the functionality (with documentation, graphics and VnV script)
  • Update the documentation for the module in which your feature will be available.

Closes #1087 (closed)

Edited by Florent Taccone

Merge request reports

Merged by Florent TacconeFlorent Taccone 1 month ago (Mar 3, 2025 1:16pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Florent Taccone added module:khione type:feature labels

    added module:khione type:feature labels

  • Florent Taccone added 1 commit

    added 1 commit

    • c332d24a - [src] adding new formula for friction under ice

    Compare with previous version

  • Florent Taccone added 2 commits

    added 2 commits

    • 9c772198 - [doc] New formula for ice cover friction in the user manual and dico
    • 6e581829 - [src] change defaut value for ice cover friction

    Compare with previous version

  • Florent Taccone added 1 commit

    added 1 commit

    • da442b55 - [vnv] adding test for new under cover friction formula

    Compare with previous version

  • Florent Taccone marked the checklist item Run compile_telemac.py --check to check FORTRAN coding conventions. as completed

    marked the checklist item Run compile_telemac.py --check to check FORTRAN coding conventions. as completed

  • Florent Taccone marked the checklist item Run pylint to check Python coding conventions. as completed

    marked the checklist item Run pylint to check Python coding conventions. as completed

  • Florent Taccone marked the checklist item Run compile_telemac.py --clean for both normal and debug configurations. as completed

    marked the checklist item Run compile_telemac.py --clean for both normal and debug configurations. as completed

  • Florent Taccone marked the checklist item Run validate_telemac.py --notebook for both normal and debug configurations. as completed

    marked the checklist item Run validate_telemac.py --notebook for both normal and debug configurations. as completed

  • Florent Taccone marked the checklist item Run doc_telemac.py if there are any modifications in the documentation. as completed

    marked the checklist item Run doc_telemac.py if there are any modifications in the documentation. as completed

  • Florent Taccone marked the checklist item Run damocles.py --eficas if there are any modifications in the dictionaries. as completed

    marked the checklist item Run damocles.py --eficas if there are any modifications in the dictionaries. as completed

  • Florent Taccone marked the checklist item Check that your feature works in both serial and parallel modes. as completed

    marked the checklist item Check that your feature works in both serial and parallel modes. as completed

  • Florent Taccone marked the checklist item Add at least one test case to check the functionality (with documentation, graphics and as completed

    marked the checklist item Add at least one test case to check the functionality (with documentation, graphics and as completed

  • Florent Taccone marked the checklist item Update the documentation for the module in which your feature will be available. as completed

    marked the checklist item Update the documentation for the module in which your feature will be available. as completed

  • Florent Taccone marked the checklist item If you added new files, run compile_telemac.py --clean --rescan and commit the updated as completed

    marked the checklist item If you added new files, run compile_telemac.py --clean --rescan and commit the updated as completed

  • Florent Taccone requested review from @fabien.souille

    requested review from @fabien.souille

  • Florent Taccone assigned to @boris.basic

    assigned to @boris.basic

  • Florent Taccone marked the checklist item Run validate_telemac.py for both normal and debug configurations. as completed

    marked the checklist item Run validate_telemac.py for both normal and debug configurations. as completed

  • Florent Taccone marked this merge request as ready

    marked this merge request as ready

  • Florent Taccone marked the checklist item Update NEWS.txt to describe your changes. as completed

    marked the checklist item Update NEWS.txt to describe your changes. as completed

  • Florent Taccone added 1 commit

    added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply

Moyen d'essai PAM - EDF R&D