Variable X concentrations in sources

I some cases it could be useful to vary the value of X concentrations in a source (for exemple if they come from measurements or from another model.

This cannot be done currently since they are defined as parameters.

changed milestone to %ThermoSysPro v4.x

added enhancement label

Would be an improvement of fluid package in general but also finds application in other projects such as Chimiscope

assigned to @guilherme.vescovi

assigned to @giorgio.simonini and unassigned @guilherme.vescovi

I have developed something for TANDEM. I will upload it.

created branch 83-variable-x-concentrations-in-sources to address this issue

created branch 83sourceWithVarX to address this issue

mentioned in commit f1f0d71e

I modified all the sources and run a few tests on existing example. In my proposal, Xi can be set by writing an expression (equation) in the parameter panel. Should we also propose an InputReal to ease the connection? Maybe with some "activable" connectors, to be explored also to solve the cardinality issue (#68).

Having a InputReal could be a good idea indeed. I did not test your fix but adding the InputReal could lead to the issue mentioned by Pierre Yves FRAVALLO in #70 (closed) and here.

Are you talking about the vectorizedConnector, the conditionalConnector or both? I think the issue only apply to the first one, while here I was thinking of using the second one in this case. As I said in issue 70, I should be able to provide some examples (in MSL or MSL modified by the CEA)...

Sorry I was unclear. I indeed had the vectorizedConnector in mind.

With hindsight maybe it was not the right gitlab issue to write it, but what I wanted to warn us about was the following: I remember vaguely a discussion where it was mentioned to pass vectors in ports (for instance for X concentrations, but it could be for other variables). Thus if we want to use vectorizedConnector (for example with a volume having N inputs and M outputs), maybe we would run into the issue mentioned by Pierre Yves FRAVALLO.

To be discussed and tested

I think that they are different issues:

• Being able to transport a changing number of variable in the connector (X concentrations...) → #62
• Being able to connect the same connector of a component to multiple components → #70 (closed)
• Being able to impose non-constant values for concentration sources → this issue

...even if they are somehow related.

assigned to @guilherme.vescovi and unassigned @giorgio.simonini