Skip to content
Snippets Groups Projects

fix for mass balance tracer in fv

Merged Florent Taccone requested to merge fix_tracer_fv into main

Reference issue

Description

Checklist

All Merge Requests:

  • Update NEWS.txt to describe your changes.
  • Run compile_telemac.py --check to check FORTRAN coding conventions.
  • Run pylint to check Python coding conventions.
  • If you added new files, run compile_telemac.py --clean --rescan and commit the updated cmdf file(s) accordingly.
  • Run compile_telemac.py --clean for both normal and debug configurations.
  • Run validate_telemac.py for both normal and debug configurations.
  • Run validate_telemac.py --notebook for both normal and debug configurations.
  • Run doc_telemac.py if there are any modifications in the documentation.
  • Run damocles.py --eficas if there are any modifications in the dictionaries.

In addition, for a new feature:

  • Check that your feature works in both serial and parallel modes.
  • Add at least one test case to check the functionality (with documentation, graphics and VnV script)
  • Update the documentation for the module in which your feature will be available.
Edited by Florent Taccone

Merge request reports

Approval is optional

Merged by Florent TacconeFlorent Taccone 1 week ago (Mar 28, 2025 8:45am UTC)

Merge details

  • Changes merged into main with 4e06cdd8 (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Florent Taccone marked the checklist item Run pylint to check Python coding conventions. as completed

    marked the checklist item Run pylint to check Python coding conventions. as completed

  • Florent Taccone marked the checklist item If you added new files, run compile_telemac.py --clean --rescan and commit the updated as completed

    marked the checklist item If you added new files, run compile_telemac.py --clean --rescan and commit the updated as completed

  • Florent Taccone marked the checklist item Run doc_telemac.py if there are any modifications in the documentation. as completed

    marked the checklist item Run doc_telemac.py if there are any modifications in the documentation. as completed

  • Florent Taccone marked the checklist item Run validate_telemac.py --notebook for both normal and debug configurations. as completed

    marked the checklist item Run validate_telemac.py --notebook for both normal and debug configurations. as completed

  • Florent Taccone marked the checklist item Run damocles.py --eficas if there are any modifications in the dictionaries. as completed

    marked the checklist item Run damocles.py --eficas if there are any modifications in the dictionaries. as completed

  • Florent Taccone marked the checklist item Check that your feature works in both serial and parallel modes. as completed

    marked the checklist item Check that your feature works in both serial and parallel modes. as completed

  • Florent Taccone marked the checklist item Add at least one test case to check the functionality (with documentation, graphics and as completed

    marked the checklist item Add at least one test case to check the functionality (with documentation, graphics and as completed

  • Florent Taccone marked the checklist item Update the documentation for the module in which your feature will be available. as completed

    marked the checklist item Update the documentation for the module in which your feature will be available. as completed

  • Florent Taccone marked the checklist item Run compile_telemac.py --check to check FORTRAN coding conventions. as completed

    marked the checklist item Run compile_telemac.py --check to check FORTRAN coding conventions. as completed

  • Florent Taccone marked the checklist item Run compile_telemac.py --clean for both normal and debug configurations. as completed

    marked the checklist item Run compile_telemac.py --clean for both normal and debug configurations. as completed

  • Florent Taccone added 1 commit

    added 1 commit

    • c86e4e4b - [src] add an if for proper use of IFAC

    Compare with previous version

  • Florent Taccone marked the checklist item Run validate_telemac.py for both normal and debug configurations. as completed

    marked the checklist item Run validate_telemac.py for both normal and debug configurations. as completed

  • Florent Taccone marked this merge request as ready

    marked this merge request as ready

  • Florent Taccone added 4 commits

    added 4 commits

    Compare with previous version

  • Florent Taccone added 1 commit

    added 1 commit

    Compare with previous version

  • Florent Taccone marked the checklist item Update NEWS.txt to describe your changes. as completed

    marked the checklist item Update NEWS.txt to describe your changes. as completed

  • Florent Taccone mentioned in commit 4e06cdd8

    mentioned in commit 4e06cdd8

Please register or sign in to reply
Loading