Improvements to TELEMAC-2D friction laws

Improvements of the friction laws of telemac2d

Reference issue

#1084 (closed)

Description

• Fix the dico to allow Colebrook-White law to be used
• Improved the fixed point algorithm of the Colebrook-White for better convergence (with initial guess from Haaland, converges in less than 5 iterations)
• Fix Haaland and Colebrook-White parameters to be consistent with free surface flows literature
• Removed clipping from Haaland, add warnings if absurb Cf instead
• VNV friction case redone from scratch (new mesh, new params, test all laws, in FV and FE)

Checklist

All Merge Requests:

• Update NEWS.txt to describe your changes.
• Run compile_telemac.py --check to check FORTRAN coding conventions.
• Run pylint to check Python coding conventions.
• If you added new files, run compile_telemac.py --clean --rescan and commit the updated cmdf file(s) accordingly.
• Run compile_telemac.py --clean for both normal and debug configurations.
• Run validate_telemac.py for both normal and debug configurations.
• Run validate_telemac.py --notebook for both normal and debug configurations.
• Run doc_telemac.py if there are any modifications in the documentation.
• Run damocles.py --eficas if there are any modifications in the dictionaries.

In addition, for a new feature:

• Check that your feature works in both serial and parallel modes.
• Add at least one test case to check the functionality (with documentation, graphics and VnV script)
• Update the documentation for the module in which your feature will be available.