Skip to content

Issue 1071: time series direction

Alexander BREUGEM requested to merge issue1071_timeseriesDir into main

Reference issue

Fix #1071 (closed)

Description

Linear interpolation cannot be performed on directions. Instead it need to be performed on the sin and cosine of the directions. Then the direction can be calculated back. This was implemented in the interpolation for the time series, such that this issue does not affect the wave directions from TOMAWAC.

Checklist

All Merge Requests:

  • Update NEWS.txt to describe your changes.
  • Run compile_telemac.py --check to check FORTRAN coding conventions.
  • Run pylint to check Python coding conventions.
  • If you added new files, run compile_telemac.py --clean --rescan and commit the updated cmdf file(s) accordingly.
  • Run compile_telemac.py --clean for both normal and debug configurations.
  • Run validate_telemac.py for both normal and debug configurations.
  • Run validate_telemac.py --notebook for both normal and debug configurations.
  • Run doc_telemac.py if there are any modifications in the documentation.
  • Run damocles.py --eficas if there are any modifications in the dictionaries.

In addition, for a new feature:

  • Check that your feature works in both serial and parallel modes.
  • Add at least one test case to check the functionality (with documentation, graphics and VnV script)
  • Update the documentation for the module in which your feature will be available.

@chi-tuan.pham I already did the merge request (as draft), such that you can have a look whether you agree. I am not sure whether it would be convenient to wait with the merge until Thomas finishes his changes in the interpolation. Note that the nearest neighbour interpolation he develops should not be affected by this issue.

@thierry.fouquet Can you also see whether you agree. I think the changes to TOMAWAC are limited to a changed function call.

Merge request reports

Loading