Changing telemac2d architecture for finite volume
Reference issue
Description
The telemac2d.F subroutine has been duplicated in telemac2d.F for the finite element resolution method and telemac2d_fv.F for finite volume resolution method. Then the routines volfin1.f and volfin2.f no longer exists and the resolution steps are called directly in telemac2d_fv.F. The telemac2d_fv routine has also be cleaned from the specific routine from FE method.
Checklist
All Merge Requests:
-
Update NEWS.txt
to describe your changes. -
Run compile_telemac.py --check
to check FORTRAN coding conventions. -
Run pylint
to check Python coding conventions. -
If you added new files, run compile_telemac.py --clean --rescan
and commit the updatedcmdf
file(s) accordingly. -
Run compile_telemac.py --clean
for both normal and debug configurations. -
Run validate_telemac.py
for both normal and debug configurations. -
Run validate_telemac.py --notebook
for both normal and debug configurations. -
Run doc_telemac.py
if there are any modifications in the documentation. -
Run damocles.py --eficas
if there are any modifications in the dictionaries.
In addition, for a new feature:
-
Check that your feature works in both serial and parallel modes. -
Add at least one test case to check the functionality (with documentation, graphics and VnV script) -
Update the documentation for the module in which your feature will be available.
Edited by Florent Taccone