Skip to content

Solve inconsistent units for pressure between TELEMAC-2D/3D and WAQTEL

Chi-Tuân Pham requested to merge pressure_unit into main

Reference issue

Fix #1014

Description

Add a new keyword PRESSURE UNIT in TELEMAC-2D and TELEMAC-3D (default = 1 for Pa/SI, other choice 2 for hPa as for meteo data file in WAQTEL). Almost every computation in TELEMAC-2D, TELEMAC-3D and WAQTEL is now computed in Pa when pressure is used (SI unit). If atmospheric or saturation vaporous pressures are read in hPa, they are then converted in Pa. Formulae for heat exchange with atmosphere are lightly changed with pressure in Pa when needed (see CALCS2D_THERMIC subroutine and EVAPO subroutine in the EXCHANGE_WITH_ATMOSPHERE module). The 2 WAQTEL examples have to be updated with this new keyword.

Checklist

All Merge Requests:

  • Update NEWS.txt to describe your changes.
  • Run compile_telemac.py --check to check FORTRAN coding conventions.
  • Run pylint to check Python coding conventions.
  • If you added new files, run compile_telemac.py --clean --rescan and commit the updated cmdf file(s) accordingly.
  • Run compile_telemac.py --clean for both normal and debug configurations.
  • Run validate_telemac.py for both normal and debug configurations.
  • Run validate_telemac.py --notebook for both normal and debug configurations.
  • Run doc_telemac.py if there are any modifications in the documentation.
  • Run damocles.py --eficas if there are any modifications in the dictionaries.

In addition, for a new feature:

  • Check that your feature works in both serial and parallel modes.
  • Add at least one test case to check the functionality (with documentation, graphics and VnV script)
  • Update the documentation for the module in which your feature will be available.
Edited by Chi-Tuân Pham

Merge request reports