Skip to content

check_cas accepting also int for float keywords

Yoann Audouin requested to merge fix_check_cas into main

Reference issue

Description

The check_cas function of telemac_cas that verifies if the data associated to each keyword of of the proper type. This check does not allow an int for a float keyword. The modification now allows int or float for a float keyword.

I added two lines in the existing test python3/steering_file/vnv_steering_file.py

Checklist

All Merge Requests:

  • Update NEWS.txt to describe your changes.
  • Run compile_telemac.py --check-code to check FORTRAN coding conventions.
  • Run pylint to check Python coding conventions.
  • If you added new files, run compile_telemac.py --clean --rescan and commit the updated cmdf file(s) accordingly.
  • Run compile_telemac.py --clean for both normal and debug configurations.
  • Run validate_telemac.py for both normal and debug configurations.
  • Run validate_telemac.py --notebook for both normal and debug configurations.
  • Run doc_telemac.py if there are any modifications in the documentation.
  • Run damocles.py --eficas if there are any modifications in the dictionaries.

Additionnaly, for a new feature:

  • Check that your feature works in both serial and parallel modes.
  • Add at least one test case to check the functionality (with documentation, graphics and VnV script)
  • Update the documentation for the module in which your feature will be available.

Merge request reports