Bug with Dirac sources belonging to several subdomains in parallel in TELEMAC-2D

In TELEMAC-2D, when using punctual sources or sources by regions, there is a bug with TYPE OF SOURCES = 2 (Dirac) when they belong to the interface between several subdomains in parallel. Bug pointed by Ismail Rifai.

added area:parallelism module:telemac-2d type:bug labels

A tentative fix is suggested in PROSOU subroutine to multiply DSCE(I) when added to SMH%R(IR) by MESH%IFAC%I(IR) not to count the contribution of discharge of sources too many times, if IR is the node index.

It works for a simple test case, to be confirmed by other validations.

A similar fix may have to be done for culverts in 2D. To be checked.

changed title from Bug with Dirac sources belonging to several subdomains in parallel to Bug with Dirac sources belonging to several subdomains in parallel in TELEMAC-2D

changed the description

Fix validated by Ismail Rifai for his TELEMAC-2D model.

mentioned in commit 0af1c59a

Indeed, there was the same bug for culverts in 2D.

Fix for punctual sources and culverts pushed in SHA 0af1c59a

closed

mentioned in commit e4b183a1

Fix pushed in SHA 0af1c59a only worked for Finite Elements when a culvert is modeled with Dirac. An additional test is done if Finite Elements or Finite Volumes are used in parallel with culverts, in order to recover previous results with Finite Volumes.

mentioned in commit e6bbe44a

mentioned in commit 1a75b22a

mentioned in commit bd5cb6c1

mentioned in commit 50967763

mentioned in commit 5c80488a

mentioned in commit 65877f71