Gaia suspension conservativity

Summary

• Context: estuary study with sentiment transport and tracers for suspension modeling.
• Bug: conservativity problems.
• Bug found by: Matthieu GONZALES DE LINARES (EDF CIH), Régis WALTHER (arteliagroup) and Mehdi-Pierre DAOU (arteliagroup)

Environment

• Operating System: Windows/Linux/MacOS
• TELEMAC version: V8P4

Steps to reproduce

TODO

What is the current bug behaviour?

TODO

What is the expected correct behaviour?

TODO

Relevant logs and/or screenshots

TODO

Possible fixes

Suggestion of modification (Régis WALTHER): Replace H<-HN, HN<-HOLD in telemac2d.F:

        IF(DEBUG.GT.0) WRITE(LU,*) 'CALLING CVDFTR SOLSYS=',SOLSYS_GAI
        CALL CVDFTR(T%ADR(ITRAC)%P,TTILD%ADR(ITRAC)%P,
     &              TN%ADR(ITRAC)%P,TSCEXP%ADR(ITRAC)%P,
!RWR     &              DIFT,ICONVFT(ITRAC),.TRUE.,HN_GAI,HOLD,HPROP,
     &              DIFT,ICONVFT(ITRAC),.TRUE.,H,HN,HPROP,
     &              UCONV_GAI,VCONV_GAI,DM1,ZCONV,SOLSYS_GAI,
     &              VISCT%ADR(ITRAC)%P,VISC_S,FLUER_ADV,
     &              SMH,YASMH,
!                              YASMI
     &              FLUDPT_ADV,.TRUE.,AM1,AM2,ZF,
     &              TBOR%ADR(ITRAC)%P,ATBOR%ADR(ITRAC)%P,
     &              BTBOR%ADR(ITRAC)%P,IT1,MASKTR,MESH,TB,
     &              T1,T2,T4,T10,TE1,TE2,TE3,
     &              KDIR,KDDL,
!                                              BILAN
     &              DT,ENTET,TETAT,1.D0,INFOGT,.TRUE.,
     &              OPTADV_TR(ITRAC),1,OPDTRA,OPTBAN,
     &              MSK,MASKEL,MASKPT,MBOR,S,MASSOU(ITRAC),
     &              1,SLVTRA(ITRAC),FLBOR,VOLU2D,V2DPAR,UNSV2D,
     &              2,FLBORTRA,FLULIM_GAI,YAFLULIM_GAI,
     &              FLULIM_GAI,.FALSE.,
     &              DIRFLU,RAIN,PLUIE,TRAIN(ITRAC),
     &              FLULIM_GAI,.FALSE.,MAXADV,TB2,NCO_DIST,NSP_DIST)