From f23d5eccf977c88d5a41d5e1c20456254ce9cb54 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Chi-Tu=C3=A2n=20Pham?= <chi-tuan.pham@edf.fr>
Date: Wed, 8 Jan 2025 10:18:56 +0100
Subject: [PATCH] [VnV][telemac3d] Update bump_static example with better
choices for 2 keywords - TIDAL FLATS = YES (default value) to improve mass
conservation (water depth + tracer, water depth up to machine accuracy) - use
preconditioning 34 for the diffusion of velocities (a little bit more
efficient)
---
examples/telemac3d/bump_static/doc/bump_static.tex | 6 ++++++
examples/telemac3d/bump_static/f3d_bump_static.slf | 2 +-
examples/telemac3d/bump_static/t3d_bump_static.cas | 8 +-------
examples/telemac3d/bump_static/vnv_bump_static.py | 6 +++---
4 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/examples/telemac3d/bump_static/doc/bump_static.tex b/examples/telemac3d/bump_static/doc/bump_static.tex
index 220951b501..6a624e2cf8 100644
--- a/examples/telemac3d/bump_static/doc/bump_static.tex
+++ b/examples/telemac3d/bump_static/doc/bump_static.tex
@@ -171,11 +171,17 @@ temperature field (less diffusion):
The extra cost for CPU time is very moderate for this test-case compared to the
PSI-type MURD scheme.
+Using \telkey{TIDAL FLATS} = YES (default choice) improves mass conservation
+(water depth + tracer, for water depth up to machine accuracy).
+
Setting the 3 keywords \telkey{IMPLICITATION FOR DEPTH} and
\telkey{IMPLICITATION FOR VELOCITIES}, \telkey{TREATMENT OF NEGATIVE DEPTHS} to
their default values (0.55 ; 0.55 ; 2) does not significantly change the results
and does not significantly increase CPU time.
+Using \telkey{PRECONDITIONING FOR DIFFUSION OF VELOCITIES} = 34 = 2 $\times$ 17
+improves the efficiency to solve the diffusion of velocities.
+
\section{Initial results (from Lamia Abbas's post-doctoral)}
If the diffusion of the tracer is not accounted, \emph{i.e.} if $\nu_{T} = 0$
diff --git a/examples/telemac3d/bump_static/f3d_bump_static.slf b/examples/telemac3d/bump_static/f3d_bump_static.slf
index b8bbf6f2d7..c0b2af5e7c 100644
--- a/examples/telemac3d/bump_static/f3d_bump_static.slf
+++ b/examples/telemac3d/bump_static/f3d_bump_static.slf
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
-oid sha256:e8b3432e313590dcd72e0da1c822c05ba66353b6b903ab53bff8b82ea143cc40
+oid sha256:aa738cd9c9c40b4e98172943a43f9ee87684257cbaffe7c818fa9fc860332d3c
size 8428092
diff --git a/examples/telemac3d/bump_static/t3d_bump_static.cas b/examples/telemac3d/bump_static/t3d_bump_static.cas
index 639d6195e3..57257ade85 100644
--- a/examples/telemac3d/bump_static/t3d_bump_static.cas
+++ b/examples/telemac3d/bump_static/t3d_bump_static.cas
@@ -1,8 +1,3 @@
-/----------------------------------------------------------------------
-/ TELEMAC-3D CALCULATION
-/----------------------------------------------------------------------
-/ SOFTWARE ENVIRONMENT
-/----------------------------------------------------------------------
FORTRAN FILE : 'user_fortran'
BOUNDARY CONDITIONS FILE : geo_bump_static.cli
GEOMETRY FILE : geo_bump_static.slf
@@ -28,8 +23,6 @@ NUMBER OF HORIZONTAL LEVELS : 40
/----------------------------------------------------------------------
/ NUMERICAL OPTIONS
/----------------------------------------------------------------------
-TIDAL FLATS : NO
-
MASS-BALANCE : YES
/CONSTANT VISCOSITY
VERTICAL TURBULENCE MODEL : 1
@@ -39,6 +32,7 @@ COEFFICIENT FOR VERTICAL DIFFUSION OF VELOCITIES : 0.003
SCHEME FOR ADVECTION OF VELOCITIES : 4
ACCURACY FOR DIFFUSION OF VELOCITIES : 1.E-8
+PRECONDITIONING FOR DIFFUSION OF VELOCITIES = 34
ACCURACY FOR PPE : 1.E-6
/----------------------------------------------------------------------
/ PHYSICAL OPTIONS
diff --git a/examples/telemac3d/bump_static/vnv_bump_static.py b/examples/telemac3d/bump_static/vnv_bump_static.py
index 023a2f315d..b42a0ca610 100644
--- a/examples/telemac3d/bump_static/vnv_bump_static.py
+++ b/examples/telemac3d/bump_static/vnv_bump_static.py
@@ -50,17 +50,17 @@ class VnvStudy(AbstractVnvStudy):
# Comparison with the last time frame of the reference file.
self.check_epsilons('vnv_1:T3DRES',
'f3d_bump_static.slf',
- eps=[1.E-9])
+ eps=[1.E-7, 1.E-9, 1.E-9, 1.E-9, 2.E-6])
# Comparison with the last time frame of the reference file.
self.check_epsilons('vnv_2:T3DRES',
'f3d_bump_static.slf',
- eps=[1.E-7,1.E-9,1.E-9,1.E-9,1.E-6])
+ eps=[1.E-7, 1.E-9, 1.E-9, 1.E-9, 2.E-6])
# Comparison between sequential and parallel run.
self.check_epsilons('vnv_1:T3DRES',
'vnv_2:T3DRES',
- eps=[1.E-7,1.E-9,1.E-9,1.E-9,1.E-6])
+ eps=[1.E-7, 1.E-9, 1.E-9, 1.E-9, 2.E-6])
def _post(self):
--
GitLab